Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize tests #1444

Merged
merged 12 commits into from
Mar 12, 2019
Merged

Normalize tests #1444

merged 12 commits into from
Mar 12, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 10, 2019

Marked version: master

Description

Normalize tests. Put non-spec tests into /new files.

New tests should be put into their own files so we don't have merge conflicts every time a PR with tests is merged.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member Author

UziTech commented Mar 10, 2019 •
edited
Loading

the tests will pass once #1439 is merged

styfle
styfle reviewed Mar 10, 2019
View reviewed changes
test/specs/run-spec.js Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
test/specs/run-spec.js Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
test/specs/run-spec.js Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
test/specs/run-spec.js Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 11, 2019
View reviewed changes
test/helpers/helpers.js Outdated Show resolved Hide resolved
@UziTech UziTech mentioned this pull request Mar 12, 2019
Closed
4 tasks
davisjam
davisjam approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@UziTech UziTech merged commit 5d6bde0 into markedjs:master Mar 12, 2019
@UziTech UziTech deleted the normalize-tests branch March 12, 2019 17:05
This was referenced Mar 12, 2019
Closed
Closed
@styfle styfle mentioned this pull request Mar 25, 2019
Merged
12 tasks
@iamstoick iamstoick mentioned this pull request Sep 10, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 11, 2024
Open
@balde-infidem balde-infidem mentioned this pull request Sep 11, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 11, 2024
Open
@restinpeaceinout restinpeaceinout mentioned this pull request Sep 12, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 12, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 12, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 13, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 13, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 13, 2024
Open
@IT21168222 IT21168222 mentioned this pull request Sep 13, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 14, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 14, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 14, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 14, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 15, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 15, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 15, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 16, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 17, 2024
Open
@anashope anashope mentioned this pull request Sep 17, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 18, 2024
Open
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 18, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Sep 18, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 19, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 19, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@davisjam davisjam davisjam approved these changes

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
category: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UziTech @styfle @davisjam